Skip to content
This repository has been archived by the owner on Jan 4, 2025. It is now read-only.

Fixes #1292 #1419

Merged
merged 5 commits into from
Jan 4, 2020
Merged

Fixes #1292 #1419

merged 5 commits into from
Jan 4, 2020

Conversation

AlonGvili
Copy link
Contributor

fixes #1292

@AlonGvili AlonGvili requested a review from adamdriscoll January 4, 2020 06:33
adamdriscoll
adamdriscoll approved these changes Jan 4, 2020
View reviewed changes
Copy link
Member

@adamdriscoll adamdriscoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for upgrading the packages as well.

@adamdriscoll
Copy link
Member

adamdriscoll commented Jan 4, 2020 •
edited
Loading

It looks like a bunch of tests are failing. I wonder if updating the packages broke something: https://dev.azure.com/ironmansoftware/universal-dashboard/_build/results?buildId=2513&view=ms.vss-test-web.build-test-results-tab

I think this is my fault. I merged the package.lock.json and it looks like I messed it up.

@adamdriscoll adamdriscoll self-requested a review January 4, 2020 15:26
@adamdriscoll
Copy link
Member

Just fixed locally. Will run another build.

@adamdriscoll
Copy link
Member

This is resolved now. Merging!

@adamdriscoll adamdriscoll merged commit 50d6aa8 into master Jan 4, 2020
@adamdriscoll adamdriscoll deleted the 1292 branch January 4, 2020 20:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamdriscoll adamdriscoll Awaiting requested review from adamdriscoll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set-UDClipboard doesn't work inside modals.
2 participants
@AlonGvili @adamdriscoll